On 06/06/2017 03:35 PM, Scott Kostyshak wrote:
> On Sun, Jun 04, 2017 at 10:58:52PM -0400, Richard Heck wrote:
>> On 06/04/2017 09:02 PM, Scott Kostyshak wrote:
>>> Commit 52eee8e5 ("Fix .po files") was not sent to lyx-cvs. I imagine it
>>> is because the commit is 13MB. I think it is a good decision not to send
>>> patches that are too large, but it would be nice to receive at least the
>>> commit message and the stats (which files were changed), and possibly a
>>> message at the end that says the patch is too large to include.
>> I'm guessing the SMTP server rejected the message. There's nothing in
>> the email sending script, so far as I'm aware, that would stop its being
>> sent. I'm not sure if there's some way to see how big the commit is and
>> omit the diff in some cases. That'd maybe be a good feature anyway,
>> since remerges are just annoying in that regard. If someone wants to
>> look at this, I can provide some pointers.
> Ah good to know. I agree it would be nice to have a limit anyway. I
> would make the limit pretty small. 500K? It is so easy to just do a
>
> git fetch
>
> and I imagine most people subscribed to the list would prefer to keep
> their mail folder small.
I've managed to produce a working script that just sends a basic
message, e.g.:
commit 938e49171b8e2203154379d6a4dd2a6400141ab8
Author: Enrico Forestieri <for...@lyx.org>
Date: Mon Dec 5 02:51:47 2016 +0100
Update it.po
po/it.gmo | Bin 489376 -> 499301 bytes
po/it.po | 3615 ++++++++++++++++++++++++++++++++++---------------------------
2 files changed, 2047 insertions(+), 1568 deletions(-)
for 'long' commits. The question is: What should count as a long commit?
Note that we are measuring here the size of the string returned by "git
show --patch-with-stat". I've tried it with 32000, and that does get rid
of the really huge ones, but it also leaves some pretty huge ones. Any
thought? If you think about an 80 character line, that 32000 bytes would
be minimum 4000 lines.
Richard
