On Tue, May 09, 2017 at 04:25:15PM +0200, Jean-Marc Lasgouttes wrote: > Le 21/04/2017 à 00:11, Guillaume MM a écrit : > > Le 08/04/2017 à 23:05, Jean-Marc Lasgouttes a écrit : > > > > > > > FileName: > > > > This would be automatically copyable and movable if not for the use of > > > > the pointer to implementation. > > > > > > What is the problem with the pointer? > > > > For motivations see for instance > > <https://oliora.github.io/2015/12/29/pimpl-and-rule-of-zero.html>. > > The spimpl template declared there looks good to me. There is no problem > with distributing Boost licenced stuff with LyX, we do it already. > > Concerning the patches, thery are in general way above my head, and I trust > your judgment. My remarks are > * it is not nice to have to use unique_ptr<InsetLabel> allover the place, I > do not really care about implementation details. Is it possible to have the > vector carry InsetLabel objects instead? > * the MouseHover.* files seems to be missing fro your third patch. > > > Speaking of review, I found that setMouseHover was never used, making > > the variable useless. What do you think? > > I'm afraid I don't understand what you mean here.
Guillaume, do you feel confident enough to push these patches for 2.3.0? Or since there is no performance gain, do you think it's best to not have them in 2.3.0 at this point? It's your call. Scott
signature.asc
Description: PGP signature
