On 03/05/2017 17:42, Tommaso Cucinotta wrote:
On 03/05/2017 17:37, Tommaso Cucinotta wrote:
Kornel, would you mind to re-run the tests ?
I have this one consistently failing:
findadv-02-in.txt: FAILED
will dig shortly (I'm going off-line a few hours).
this is what I found:
1) started from re-running all the findadv-*.txt tests, and got
all passing, EXCEPT 02, 08, 20, 21, re-04
2) I need this [1], in order to have findadv-02 and -08 pass;
the problem is that multiple [Enter] or others seem to hit LyX too fast,
and, e.g., the second [Enter] arrives while focus was not restored yet on
the findadv pane, so it deletes the selected found segment from the previous
[Enter] key press; guess this is related to [515ca693/lyxgit] et al.
3) all others are "flickering" pass/fail, except findadv-21-in.txt that
keeps consistently failing, because, AFAICR, this one should be the
bug about lists matching enums and vice-versa, which is still open
(no on-line access while writing this e-mail)
AFAICS, issues just related to the autotests machinery and keytest.py, so clear
to go for the release, there's no actual problem, as these tests would all pass
if run manually by a user (except -21).
Thanks,
T.
[1]
$ git diff
diff --git a/development/autotests/findadv-02-in.txt
b/development/autotests/findadv-02-in.txt
index 7fb840e6..9954b499 100644
--- a/development/autotests/findadv-02-in.txt
+++ b/development/autotests/findadv-02-in.txt
@@ -7,6 +7,7 @@ KK: x^(a) +\\frac 1+x^(a) \[Down]1-x^(a) \C\[Home]
KK: \CF
KK: \Cmx^(a) \[Tab]
KK: \Cmx_a
+KD: 100
KK: \[Return]\[Return]\[Return]
KD: 60
KK: \Cs
diff --git a/development/autotests/findadv-08-in.txt
b/development/autotests/findadv-08-in.txt
index a0f6d952..eb0699cf 100644
--- a/development/autotests/findadv-08-in.txt
+++ b/development/autotests/findadv-08-in.txt
@@ -20,6 +20,7 @@ KK: o
KK: \Axregexp-mode\[Return]
KK: [\\w]* a
# select whole words
+KD: 100
KK: \Ac\Ac
# search next
KK: \Al
@@ -33,7 +34,6 @@ KK: \C\[Home]\Axdialog-show findreplaceadv\[Return]
KK: \Axregexp-mode\[Return]
KK: .* \Ac\Ac
KK: \Al\Al\Al
-KK: \[Tab]\[Return]
TestEnd
Lang C
Assert pcregrep -M 'Putting selection at .*idx: 0 par: 0 pos: 10\n with len:
3' lyx-log3.txt