Angus Leeming <[EMAIL PROTECTED]> writes:
| On Saturday 24 February 2001 00:34, Lars Gullik Bjønnes wrote:
| > | Dear all,
| > |
| > | The MVC branch is ready to merge back into HEAD. I'll leave things
| > | as they are for the weekend and then create the patch on Monday.
| >
| > Ok, before we do the merge:
| > - get people to try out your patch/branch
| > - get people to read the patch
| > - wait for "Go!" from me.
|
| Ok, people. Please do as the man says, if you haven't done so already. Check
| out BRANCH_MVC and have a look at frontends/controllers/ and at
| frontends/xforms/FormCitation.[Ch] and frontends/kde/FormCitation.[Ch].
|
| Compilation should be as normal:
| ./autogen.sh
| ./configure frontend=[xforms,kde]
| make
|
| In fact, their should be no user-visible changes for the xforms Citation
| dialog. The kde dialog has a new ButtonController. In both cases, the old
| ButtonController bugs will be present becuase I've reverted my temporary fix.
| I'll implement Allan's new-and-improved suggestion once this code is in HEAD.
|
| Atlternatively (and equivalently), I've made a patch against the current
| HEAD. It's attached to this mail.
|
| Lars, can I leave this with you now, please?
One thing I have been wondering about is why the buttoncontroller
takes a pointer to a buttonpolicy, better would be a a traits class
and make the ButtonController a template class that thakes the needed
trait.
template <class BP>
class ButtonController : public noncopyable {
public:
typedef BP Policy;
private:
Policy bp;
}
Perhaps not as easy to do now.
Another options is to have all the different policies as static
objects somewhere. (what I really do no like is the delete &bp_ i see
in some destructors)
Lgb
