Le 06/01/2017 à 16:13, Richard Heck a écrit :
I guess I'd be inclined to go
ahead and commit it, then. Maybe we can just encourage as many people as
possible to use the 2.2.x branch (if they're not already using master),
so it gets tested.

I would agree with that.

One question: Do you want to leave all the #ifdefs in the 2.2.x code?
They seem to me to be less useful here than in master, but maybe they do
no harm. But if they are left, we should probably add something to the
release notes about what they do and how to enable/disable them.

The goal is to remain as close as possible to master and to allow easily to enable/disable a certain cache in certain conditions (e.g. "Qt 5.3.7 with Fedora 21", I don't know) so that the code works well for everybody. So actually, it may be very useful in stable.

I removed the pmprof code hooks, though.

JMarc

Reply via email to