Le 25/11/2016 à 20:50, Scott Kostyshak a écrit :
On Fri, Nov 25, 2016 at 02:32:37PM -0500, Scott Kostyshak wrote:
I think the line-breaking in the warning dialog should be improved. The
horizontal width is larger than my 13 in. screen. See attached.
Note that the linebreaking on the *other* warning (the Run/ Do Not run)
is fine.
This dialog is custom (GuiToggleWarningDialog). All other messages
dialogs use QMessageBox. GuiToggleWarningDialog is essentially a
QMessageBox::warning with an added checkbox.
Starting from Qt5.2, QMessageBox supports adding a checkbox
(QMessageBox::setCheckBox). I suggest reimplementing
GuiToggleWarningDialog as a QMessageBox, for consistency and to fix the
issue. One will need an #if QT_VERSION >=... directive though.
Also regarding the "first" warning (the "Launch of external converter is
forbidden" warning, which is the one I'm referring to above), although I
have not closely followed the conversation I have the following comment:
I think it should be converted to an error and/or I don't think there
should be a checkbox "Do not show this warning again".
I agree. Note that this also fixes the the line breaking issue since
QMessageBox is used instead of GuiToggleWarningDialog in that case. (But
it would still be good to fix GuiToggleWarningDialog.)
Guillaume
