On Wed, Nov 02, 2016 at 05:14:20PM +0100, Juergen Spitzmueller wrote:
> commit 3374b8548b2807def95904d81746fd027e06ebf4
> Author: Juergen Spitzmueller <sp...@lyx.org>
> Date:   Wed Nov 2 17:07:49 2016 +0100
> 
>     Fix usage of multiple varieties of the same polyglossia language.
>     
>     1. We must always output all (diverging) options, including
>        default options; if not, default options might get overwritten.
>     
>     2. Do not output options in \setotherlanguage, since we might have
>        multiple "other languages" varieties from the same language (such
>        as naustrian, nswissgerman). And the options are output for the
>        language switches anyway.
>     
>     Hence, LaTeXFeatures::getPolyglossiaLanguages() does not have to record
>     varieties. This was not done correctly anyway, since the map allowed
>     for one entry per language only.

> @@ -1000,7 +1010,7 @@ Language serbian-latin
>       GuiName          "Serbian (Latin)"
>       BabelName        serbian
>       PolyglossiaName  serbian
> -     PolyglossiaOpts  "script=Latin"
> +     PolyglossiaOpts  "script=latin"
>       QuoteStyle       german
>       Encoding         iso8859-2
>       LangCode         sr_RS-Latin

The following tests are now failing because of this change:

  export/examples/sr/Braille_dvi3_systemF
  export/examples/sr/Braille_pdf4_systemF
  export/examples/sr/Braille_pdf5_systemF
  export/examples/sr/splash_dvi3_systemF
  export/examples/sr/splash_pdf4_systemF
  export/examples/sr/splash_pdf5_systemF

For example, splash_pdf4 gives the following error:
! Package polyglossia Error: Unknown script `latin' for Serbian language

The change reverted 4f2536af. I think it is confusing because
PolyglossiaName is the lowercase "latin" but I believe it is correct to
set PolyglossiaOpts to the uppercase "Latin". If you agree, I think we
should additionally put a comment right above that line because it is so
easy to forget.

Scott

Attachment: signature.asc
Description: PGP signature

Reply via email to