Questions:
We're not supposed just to use "Yes" and "No", right?
This changes the format of some file or other. Which one? Is this a
format change in the relevant sense of "master only"?
> diff --git a/src/Converter.cpp b/src/Converter.cpp
> index 58e486e6..02631ca4 100644
> --- a/src/Converter.cpp
> +++ b/src/Converter.cpp
>
> + if (conv.need_auth()) {
> + static const char securityWarning[] =
This can just be a string yes? I don't think we usually use char[].
> diff --git a/src/graphics/GraphicsConverter.cpp
> b/src/graphics/GraphicsConverter.cpp
> index 67b1580f..6017073f 100644
> --- a/src/graphics/GraphicsConverter.cpp
> +++ b/src/graphics/GraphicsConverter.cpp
> @@ -15,6 +15,7 @@
> #include "Converter.h"
> #include "Format.h"
>
> +#include "frontends/alert.h"
> #include "support/lassert.h"
> #include "support/convert.h"
> #include "support/debug.h"
> @@ -372,6 +373,15 @@ static void build_script(string const & from_file,
> outfile = tempfile.name().toFilesystemEncoding();
> }
>
> + if (conv.need_auth()) {
> + static const char securityWarning[] =
Same here?
Richard
