On Sun, Oct 09, 2016 at 07:24:25PM +0200, Enrico Forestieri wrote:
> On Sat, Oct 08, 2016 at 10:09:54AM -0400, Scott Kostyshak wrote:
>
> > On Sat, Oct 08, 2016 at 11:02:17AM +0200, Enrico Forestieri wrote:
> > > On Fri, Oct 07, 2016 at 11:41:25PM -0400, Scott Kostyshak wrote:
> > >
> > > > The attached patch is simple but I have not made a change like this
> > > > before so I wanted to check on the list.
> > >
> > > In general, all capitals is used for preprocessor macros and in LyX
> > > private mambers have a trailing underscore. So, I suggest changing
> > > ZOOM_MIN to zoom_min_.
> >
> > Ah yes I should have remembered that. Thanks for catching it.
> >
> > I originally had it in capitals because in Server.h we have
> > enum { MAX_CLIENTS = 10 };
> >
> > so I first used an enum.
> >
> > Is there any advantage/preference for using an enum over a const int in
> > this situation?
>
> I don't think so. If you like all capitals, go for it.Lowercase is fine, and I like using an int instead of an enum because this approach generalizes to other situations (e.g. if I wanted a const string) that I don't think an enum does. I just pushed a commit but I forgot to append the underscore. I'll fix that now. Thanks for the feedback. Scott
signature.asc
Description: PGP signature
