On Sat, Sep 24, 2016 at 12:29:42PM +0200, Enrico Forestieri wrote: > On Sat, Sep 24, 2016 at 08:35:47AM +0200, Jürgen Spitzmüller wrote: > > > Am Samstag, den 24.09.2016, 03:34 +0200 schrieb Enrico Forestieri: > > > LyX was making a real mess when switching languages with polyglossia. > > > I attach here a couple of simple test cases demonstrating it. > > > Should be fixed at 3bc08a76. > > > > Thanks for fixing. This bug was a real PITA.
Yes thank you! This has been bothering us for a while. Below is the diff in our ctests of before/after your commit. I will put comments in-between to interpret them. The comments are below the test output that they refer to. If you are not interested in the "good" comments, you can just read the part regarding "es/Additional_pdf5_systemF" and skip the rest. $ diff ctests_before ctests_after 1a2,3 > 301:INVERTED.LYXBUGS_export/export/latex/languagenesting_enumerate_and_lyxcode_pdf5_systemF > 303:INVERTED.LYXBUGS_export/export/latex/languagenesting_index_inset_pdf5_systemF This means that two exports that were not working before now work thanks to your commit. I believe that these were the only two dedicated tests to language nesting that showed known problems in LyX (there are other tests dedicated to language nesting but they passed before and after your commit). So this is good. We will soon "uninvert" these tests, so that they become normal tests and thus we can use them to detect regressions to the fix that you just made. > 957:export/doc/es/Additional_dvi3_systemF > 962:export/doc/es/Additional_pdf4_systemF > 964:export/doc/es/Additional_pdf5_systemF This means that these exports used to pass and after your commit now they fail for me. Doing the export manually, I get the following error: ! Extra }, or forgotten \endgroup. To reproduce, open doc/es/Additional.lyx, go to Document > Settings > Fonts and check "Use non-TeX fonts" and set them to e.g. FreeSans. Then compile with PDF (LuaTeX). Note that there is a possibility that we introduced a hack to work around the language nesting bug. I don't remember. I looked briefly for e.g. an ERT '}' but didn't see anything strange. > 1608:INVERTED.LYXBUGS_export/doc/nb/Intro_dvi3_systemF > 1613:INVERTED.LYXBUGS_export/doc/nb/Intro_pdf4_systemF > 1615:INVERTED.LYXBUGS_export/doc/nb/Intro_pdf5_systemF > 1789:INVERTED.LYXBUGS_export/doc/sk/Intro_pdf4_systemF These exports also go from failing to passing thanks to your commit. < 3783:export/examples/fr/beamer-article_dvi3_systemF < 3788:export/examples/fr/beamer-article_pdf4_systemF < 3790:export/examples/fr/beamer-article_pdf5_systemF These used to fail and now pass. Scott
signature.asc
Description: PGP signature
