On Mon, Sep 12, 2016 at 09:50:54AM +0000, Guenter Milde wrote:
> On 2016-09-11, Scott Kostyshak wrote:
> 
> > [-- Type: text/plain, Encoding:  --]
> 
> > On Sun, Sep 11, 2016 at 06:46:47PM +0000, Guenter Milde wrote:
> 
> >> Could you please change the test reference accordingly?
> 
> > Done at d3c63f97.
> 
> Thank you.
> 
> I changed this in 99eeb29e5863516220eb823c2bcc276761107c41 to make the input
> sample "box-color*.tex" compilable without errors and give a clean import to
> LyX:
> 
> Load required package textcomp.
> Replace call to non-existent packages textcyr and textgreek with the backup 
> definition of the commands as done by LyX export.
> Do not load marvosym (clash with pifont) (LyX does not load the package 
> either).
> Remove invalid command \\ascii.

Sounds good. I just ran the tex2lyx tests on current master and they all
pass so since you confirm that the changes to the reference tests are
correct, I think we proceeded correctly.

I'm guessing you already know, but I had forgotten that to update the
tests (e.g. after you confirm that the changes are indeed correct), with
CMake we can run "make updatetex2lyxtests" in the root of the build
directory. I had to reread Development.lyx to realize this.

Scott

Attachment: signature.asc
Description: PGP signature

Reply via email to