On Sun, Aug 07, 2016 at 09:29:31PM -0400, Richard Heck wrote: > On 08/07/2016 03:24 PM, Scott Kostyshak wrote: > > On Tue, Jul 12, 2016 at 05:57:41AM +0200, Richard Heck wrote: > >> commit 5df323a0dd564f00c5ab085a3570957ad76b21d3 > >> Author: Richard Heck <rgh...@lyx.org> > >> Date: Mon Jul 11 23:56:32 2016 -0400 > >> > >> Introduce "inverted" branch insets: These are branches whose content > >> is output when a branch is NOT activated. Fixes bug #7698. > >> > >> At the moment, inversion is controlled through the branch settings > >> dialog. There is no provision for inserting inverted insets directly, > >> or for changing them from the context menu. Both of these could be > >> done, of course. The latter would need LFUN_BRANCH_TOGGLE_INVERTED. > > This commit broke tex2lyx tests. > > I'm not sure why this would be. > > > If the lyx2lyx conversion from the old to the new format is empty, or > > if tex2lyx does not yet output the changed feature, you do not need > > any further tex2lyx changes. LyX Document > > Surely tex2lyx does not know about branches?
No but it does not know that it does not need to know about branches :) I don't know much about these tests, but from what I understand the tests compare .lyx files created from tex2lyx to reference .lyx files. These reference .lyx files are files that we know to be correct. Thus we compare .lyx files created from tex2lyx to .lyx files that we know tex2lyx used to produce. If there is any file format change (such as this one), the .lyx files will not be equal. Thus, the format of the reference .lyx files needs to be updated. This must be done with care and manual inspection is required (that is why it is not automated). I'm not sure if I got that right. To be sure take a look at "Section 4.2.2 Updating test references" in Development.lyx for a detailed explanation by Georg. Note that this section is referenced by Section 2.3 (the "How to update the file format" section). Scott
signature.asc
Description: PGP signature
