On 08/01/2016 06:49 PM, Guillaume Munch wrote:
> diff --git a/src/frontends/qt4/GuiFontLoader.cpp 
> b/src/frontends/qt4/GuiFontLoader.cpp
> index cc092f5..2dacc42 100644
> --- a/src/frontends/qt4/GuiFontLoader.cpp
> +++ b/src/frontends/qt4/GuiFontLoader.cpp
> @@ -373,9 +373,13 @@ GuiFontInfo::GuiFontInfo(FontInfo const & f)
>  
>  bool FontLoader::available(FontInfo const & f)
>  {
> -     // FIXME THREAD
> -     static vector<int> cache_set(NUM_FAMILIES, false);
> -     static vector<int> cache(NUM_FAMILIES, false);
> +#if defined(__GNUC__) && (__GNUC__ == 4) && (__GNUC_MINOR__ == 6)

I meant to ask before: Even if we're requiring gcc >= 4.6 (right?), is
it worth changing this to:

> (__GNUC_MINOR__ <= 6)

just in case someone ever wanted to try to compile with 4.5? Or would
that be impossible anyway? More generally, do we need something here for
other compilers?

Actually, maybe a better way to do it would be to invert the test. E.g.:

> #if [CONDITIONS ARE GOOD]
>       thread_local QVector<QPoint> points(32);
> #else
>       static QVector<QPoint> points(32);
> #endif

Maybe we could just add a test to configure to see whether we have
thread_local?

Richard

Reply via email to