On 07/25/2016 09:58 PM, Guillaume Munch wrote: > Le 26/07/2016 à 00:15, Uwe Stöhr a écrit : >> I found time to compile today's 2.2.x branch. I get this warning that >> could and should be avoided: >> >> TextMetrics.cpp >> D:\LyXGit\2.2.x\src\RowPainter.cpp(590): warning C4244: 'initializing': >> conversion from 'double' to 'int', possible loss of data >> [D:\LyXGit\2.2.x\compile-2015\src\LyX.vcxproj] >> > > I agree with "should": when I read this line, it is not obvious to me > that it hides a narrowing and if it does, I do not immediately know > whether it was intended (other than confidence in the author). It > is important to have such warnings.
In this case, it looks as if it really should be a double: I.e., I can make it a double, and it still compiles. Richard
