Am 17.07.2016 um 18:37 schrieb Jean-Marc Lasgouttes <lasgout...@lyx.org>: > > Le 17/07/2016 12:52, Enrico Forestieri a écrit : >> On Wed, Jul 13, 2016 at 11:01:56PM -0400, Scott Kostyshak wrote: >> >>>> Attached a refined version that accounts for the path of the actually >>>> checked tool, instead of always using the moc path (even if they are >>>> the same in practice). >>> >>> Tested and works well. >> >> Committed at 0c7bd9a5. > > Enrico, I still have some questions about that code: > > * is using $(dirname foo) portable? I would have used `dirname foo`, but I do > not really know why.
According to this article http://stackoverflow.com/questions/4708549/whats-the-difference-between-command-and-command-in-shell-programming the first form is the preferred one. I think it’s easier to read because I’m used to see matching pairs of parenthesis. Another argument is the possibility to nest this construct easily. Finally - it’s POSIX. Stephan > > * what is the reason why you search for tools without path (AC_CHECK_PROG) in > some cases? I did think it was cleaner at some time, but now I know better :) > > When everything is sorted out, can you do the backport to 2.2.2? I think you > are the one who knows best what commits should be cherry-picked. > > JMarc
