On Sun, Jul 10, 2016 at 12:02:47PM +0200, Kornel Benko wrote: > Am Sonntag, 10. Juli 2016 um 11:53:37, schrieb Enrico Forestieri > <for...@lyx.org> > > > > I suggest that I commit the previous patch you posted and then you > > can start from there. > > Please no. I am convinced now that you were right about QPA_XCB, so I am not > happy to commit something which is worse than I already have.
Ok, I'll wait for your commit. Then, please, update and post the patch for cmake corresponding to the upcoming one from me, so that I can commit it altogether. > > As regards the name of variables, I suggest > > that you simply rename QT_USES_X11 as HAVE_QT5_X11_EXTRAS, because > > that is what really that test is for. If you need to use QT_USES_X11 > > somewhere else, it should be set to true if QPA_XCB is true, because > > that is what really guarantees that X11 is the default backend. > > I need QT_USES_X11 for creation of xvkbd. > In QT4 we use QT_USES_X11 too, so renaming is not so good idea. There is a misunderstanding here. What I was suggesting is that, for Qt5, instead of QT_USES_X11 == Qt5X11Extras_FOUND, it should be QT_USES_X11 == QPA_XCB_FOUND. -- Enrico
