On 06/21/2016 07:48 PM, Scott Kostyshak wrote:
> On Sat, Apr 16, 2016 at 01:43:18PM -0400, Scott Kostyshak wrote:
>> On Sat, Apr 16, 2016 at 08:35:54AM -0400, Richard Heck wrote:
>>> On 04/15/2016 05:45 PM, Scott Kostyshak wrote:
>>>> On Tue, Mar 29, 2016 at 06:09:56PM -0400, Scott Kostyshak wrote:
>>>>> On Tue, Mar 29, 2016 at 10:49:55AM +0200, Jean-Marc Lasgouttes wrote:
>>>>>> Le 28/03/2016 00:04, Scott Kostyshak a écrit :
>>>>>>> It seems we currently use "git show ${hash}" in our script. Instead of
>>>>>>> doing two commands like I naively suggested above, what about the
>>>>>>> following?
>>>>>> What about "git show --stat"?
>>>>> Yes that is better than what I proposed. We should do
>>>>>
>>>>> git show --patch-with-stat
>>>>>
>>>>> so that both the patch and the stat are shown.
>>>> Richard are you able to change this? I think it would mean changing the
>>>> following in git_show:
>>>>
>>>> p = subprocess.Popen(['git', 'show', hash], stdout=subprocess.PIPE)
>>>>
>>>> to
>>>>
>>>> p = subprocess.Popen(['git', 'show', '--patch-with-stat', hash],
>>>> stdout=subprocess.PIPE)
>>>>
>>>> git show is also used in get_commit_info():, but if I understand
>>>> correctly we don't need to change it there (I'm not confident about this
>>>> though).
>>> I will be able to do so, but I'll need to read this thread through and
>>> understand exactly what we are trying to do.
>> OK it is not urgent.
> Just pinging Richard in case he happens to find time to take a look.
> It's still not urgent of course.
Should work now.
rh
