On Sat, May 21, 2016 at 11:13:54AM +0200, pdv wrote:
> If one has 2 documents open in LyX 2.2 in 2 separate windows and one wants
> to bring the one in the back to the front via the menu View/Hidden/... then
> (on a mac, OSX 10.11.4) nothing happens. Although the window has been
> activated, it's not brought to the front. [When switching to e.g. the Finder
> and then back to LyX by clicking on the LyX icon in the Dock, the hidden
> window will now be shown in front.]
> 
> The problem is solved by adding a raise() call to the activateWindow() call
> in GuiView.cpp (see included patch).
> 
> Regards,
> 
> P. De Visschere

> diff --git a/src/frontends/qt4/GuiView.cpp b/src/frontends/qt4/GuiView.cpp
> index c2101f3..89bff9a 100644
> --- a/src/frontends/qt4/GuiView.cpp
> +++ b/src/frontends/qt4/GuiView.cpp
> @@ -3615,6 +3615,7 @@ void GuiView::dispatch(FuncRequest const & cmd, 
> DispatchResult & dr)
>                       for (; i != ids.size(); ++i) {
>                               GuiView & gv = guiApp->view(ids[i]);
>                               if (gv.workArea(*buffer)) {
> +                                     gv.raise();
>                                       gv.activateWindow();
>                                       gv.setBuffer(buffer);
>                                       break;

Since this part of the code is contained in "case LFUN_BUFFER_SWITCH"
and is only reached if there are multiple views, I think it could go
in for 2.2.0.

Let's see if anyone else has an opinion, otherwise I will test on Linux
and commit it before rc2.

Scott

Attachment: signature.asc
Description: PGP signature

Reply via email to