On Friday 16 February 2001 19:20, Dekel Tsur wrote:
> On Fri, Feb 16, 2001 at 10:34:50AM +1000, Allan Rae wrote:
> > On Thu, 15 Feb 2001, Michael Schmitt wrote:
> > > in the citation dialog there is a problem with the OK button:
> > >
> > > 1. Select a citation
> > > 2. Select another citation
> > > 3. Remove one of the two citations
> > > 4. Click on the other citation
> > > --> the OK button is disabled
> >
> > This is the problem Angus is asking ButtonController questions about. It
> > is being worked on and a fix should be available soon.
>
> It seems that the problem described above has already been fixed.
Not really. A possible solution has been submitted (by me), the main
intention being to trigger debate leading to a best solution. Allan has just
proposed a better solution than my original (see
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg19406.html)
> But there are still some issue with the enabling of the OK/Update buttons:
> 1. If I open a Citation inset, add a citation and then delete it, then the
> OK/Update buttons do not become disabled.
Oh, come on! I don't think we should hold the user's hand! The
ButtonController is meant to change state when something is input. It knows
nothing about the original state of all inputs, nor should it.
This won't change, therefore.
> 2. When inserting a new reference, if I press the "goto ref" button then
> the OK/Update buttons become disabled.
> This also happen if you open an existing reference, make a change, and then
> press the "goto ref" button.
That's because I implemented my possible fix for the Citation dialog only.
Once we get the fix right, then the other dialogs will follow.
> 3. Making a change in the "text after" field in the citation dialog doesn't
> enable the OK/Update buttons.
Really? Then I'd better port something over from the NATBIB branch!
Angus
