On 04/24/2016 01:10 PM, Scott Kostyshak wrote: > In 2.1.x, because of a bug in our validator code, we allowed negative > values to be input into some document settings. This bug has been fixed > for 2.2.0dev but what that means is that if you open such a document > with LyX 2.2.0dev, you will not be able to save any changes to document > settings unless you correct the negative values and it is not obvious to > the user that this must be done. I can imagine this causing some > confusion. > > For more details, see: > http://www.lyx.org/trac/ticket/10095#comment:2 > > I'm not sure that we want to do anything for 2.2.0, but I wanted to > check with the list to see the thoughts of others. For example, we could > change the validators in page margins to allow negative values, which > seem to work as intended with LaTeX. Or we could provide a warning when > creating the document settings dialog that explains why the "OK" button > is disabled.
This does seem kind of bad. A simple fix would be some lyx2lyx code that fixed the negative settings somehow, perhaps resetting them to the default (which is how they will be treated anyway, I'd assume). Alternatively, on reading the document, we could convert invalid negative values to the default. Then when the document is saved, it will be saved with correct values. And if one opens the document settings, you'll have acceptable values, too. Richard
