Am 18.04.2016 um 05:01 schrieb Richard Heck <rgh...@lyx.org>: > > On 04/17/2016 11:12 AM, Stephan Witt wrote: >> Am 17.04.2016 um 16:18 schrieb Richard Heck <rgh...@lyx.org>: >>> On 04/17/2016 09:09 AM, Stephan Witt wrote: >>>> Am 16.04.2016 um 22:30 schrieb Stephan Witt <sw...@lyx.org>: >>>>> commit 5f368aec7b3206c873c94294def906911523dc8e >>>>> Author: Stephan Witt <sw...@lyx.org> >>>>> Date: Sat Apr 16 22:30:33 2016 +0200 >>>>> >>>>> Handle activateWindow in LFUN_BUFFER_SWITCH like in saveBufferIfNeeded() >>>>> and doShowDialog() methods. >>>>> This is a requirement on Mac to get the current buffer view topmost >>>>> after buffer switch. >>>>> >>>>> diff --git a/src/frontends/qt4/GuiView.cpp b/src/frontends/qt4/GuiView.cpp >>>>> index c2101f3..8133ac2 100644 >>>>> --- a/src/frontends/qt4/GuiView.cpp >>>>> +++ b/src/frontends/qt4/GuiView.cpp >>>>> @@ -3615,7 +3615,9 @@ void GuiView::dispatch(FuncRequest const & cmd, >>>>> DispatchResult & dr) >>>>> for (; i != ids.size(); ++i) { >>>>> GuiView & gv = guiApp->view(ids[i]); >>>>> if (gv.workArea(*buffer)) { >>>>> + gv.raise(); >>>>> gv.activateWindow(); >>>>> + gv.setFocus(); >>>>> gv.setBuffer(buffer); >>>>> break; >>>>> } >>>> Ok to backport? Without it there is an serious usability problem >>>> when using buffer switch on Mac. I don’t know if it is reproducible >>>> on Linux. See the emails from Anders Ekberg with subject >>>> "Aw: LyX2.2rc1 hidden windows bug(?) on Mac“ >>> This can go to 2.1.5 and to 2.2.2-staging. Or do you think it's a bad >>> enough bug for 2.2.1? >>> >>> Richard >> It makes the handling of activateWindow() uniform and it looks simple. >> But I've never noticed the bug - Anders sent the report. I’ve included >> him in CC. AFAICS in full-screen it’s a real problem. > > OK. Fine for 2.1.5 and for 2.2.1-staging, then.
I’ve tested it now with 2.1.4.1 and it’s not needed to backport it to 2.1.x. The effect is new with Qt-5.x and therefore it cannot happen with LyX 2.1. Stephan