On Mon, Apr 18, 2016 at 11:58:42AM +0200, Jean-Marc Lasgouttes wrote:
> Le 15/04/2016 21:56, Scott Kostyshak a écrit :
> > On Fri, Apr 15, 2016 at 09:48:38PM +0200, Jean-Marc Lasgouttes wrote:
> > > Le 15/04/16 21:45, Scott Kostyshak a écrit :
> > > > On Fri, Apr 15, 2016 at 04:19:20PM +0200, Jean-Marc Lasgouttes wrote:
> > > > > Le 13/04/2016 21:27, Jean-Marc Lasgouttes a écrit :
> > > > > > It is indeed in SOURCEFILES, and it had been there all the time. I 
> > > > > > guess
> > > > > > it should be removed, but with care.
> > > > > > 
> > > > > > Do you build before doing "make dist"?
> > > > > 
> > > > > I'd say that this patch is all we need.
> > > > 
> > > > If "I'd say" means you are confident, then go ahead. Let me know if you
> > > > want me to test something (e.g. apply your patch and make the tar file
> > > > and check).
> > > 
> > > I am confident, but then the makefile was like that from the start in 
> > > 2007,
> > > so that makes me more nervous. But then, what could possibly go wrong? ;)
> > 
> > Normally I probably wouldn't want to change something at this point, but
> > on 2.2.0rc1 that file takes up 24MB in the extracted tar ball so it
> > would be nice to get rid of it.
> 
> Is this a +1 for 2.2.0?

Yes. Since you are confident, I think decreasing the tar ball by 20% is
significant.

Scott

Attachment: signature.asc
Description: PGP signature

Reply via email to