Am 15.04.2016 um 11:06 schrieb Scott Kostyshak <skost...@lyx.org>:
>
> On Fri, Apr 15, 2016 at 10:36:59AM +0200, Stephan Witt wrote:
>> Am 15.04.2016 um 09:51 schrieb Scott Kostyshak <skost...@lyx.org>:
>>>
>>> On Thu, Apr 14, 2016 at 08:53:24PM +0200, Stephan Witt wrote:
>>>> Am 14.04.2016 um 20:16 schrieb Guillaume Munch <g...@lyx.org>:
>>>>>
>>>>> Le 14/04/2016 19:05, Stephan Witt a écrit :
>>>>>>
>>>>>> Yes, it’s attached. Thanks for testing.
>>>>>>
>>>>>
>>>>>
>>>>> Works well on Linux+qt{4,5}.
>>>>>
>>>>> Two remarks:
>>>>>
>>>>> * isFixedPitch() would be in an anonymous namespace by what I know of
>>>>> LyX's code style.
>>>>> * In my patch I compute typewriterFontName() from typewriterSystemFont.
>>>>> Would you make this change?
>>>>
>>>> Like this one?
>>>
>>> If you do not set the font to 12 point on Mac, it is too small?
>>
>> Yes, this is what Joel said I’d say it too.
>
> True, and comparing with the size on my system, it does seem to be a
> difference in platforms and not a difference in what we consider to be
> small.
>
>>> I did read the thread and that you tried to configure Qt system
>>> settings, but it seems unfortunate to introduce platform-dependent
>>> code for something like this.
>>>
>>> Just to confirm: hard-coding the font size should not change anything
>>> for HiDPI right?
>>
>> It does the Right Thing - because it’s not in pixels but in points.
>
> OK.
>
>>> Doing a grep for "setPointSize" does not show any other examples of
>>> hardcoding, if I understand correctly. Why is it only needed here?
>>
>> Because it’s a system font to paint with being used only here.
>>
>> I’ve extended the patch with comments and I’ll provide some screen shots
>> to illustrate the font sizes.
>
> I see.
>
> Please commit.
>
> Scott
Done with 87c85303c5c5980b1189867c5dc9e711acf77c07.
Stephan
