On Wed, Mar 30, 2016 at 05:22:25PM +0200, Jean-Marc Lasgouttes wrote: > Le 30/03/2016 00:55, Scott Kostyshak a écrit : > >On Tue, Mar 29, 2016 at 10:56:31AM +0200, Jean-Marc Lasgouttes wrote: > >>Le 25/03/2016 22:20, Jean-Marc Lasgouttes a écrit : > >>>Le 25/03/2016 20:08, Kornel Benko a écrit : > >>>>Am Freitag, 25. März 2016 um 19:51:53, schrieb Jean-Marc Lasgouttes > >>>><lasgout...@lyx.org> > >>>>... > >>>>>--- > >>>>> development/FORMAT | 4 + > >>>>> lib/doc/de/EmbeddedObjects.lyx | 45901 > >>>>>------------------- > >>>> > >>>>What is this? 45901 deleted lines? > >>> > >>>This is what happens when one runs updatedocs.py and the lyx2lyx > >>>crashes. A deleted file :( The same holds for updatelayouts.py, but I > >>>caught this one at the time. > >>> > >>>The following patch is more reasonable. > >> > >>So, what shall I do with this patch? In my personnal tree I have also > >>updated Embedded.lyx (the only manual that mentions LongTableNoNumber). > > > >+1 please commit. Thanks for the patch. > > Shall I update docs and layouts or will you do it before release?
Yes please do it. The reason why I think it is preferable for you to do it is in the Development manual: "Update LyX's .lyx documentation files to the new format. The developer who makes the change knows best what changes to expect when inspecting the resulting diff. Because of this, you might be able to catch a bug in the lyx2lyx code that updates the format just by taking a quick scan through the large diff that is the result. Another advantage is that if later we suspect a bug in lyx2lyx we can easily see which layout update made an unexpected change by looking at the git log of a .lyx file that suffers the problem. To do this, first make sure that there are no changes to the git repository that you will not want to commit (this is needed because it will be convenient to commit with the command git commit -a). Then run the following command in the root folder of the source: python development/tools/updatedocs.py. Look at the resulting changes using the command git diff. If anything looks surprising, please investigate. Keep in mind that the case of LFUNs.lyx is special, because it is first generated with gen_lfuns.py before being converted to the latest format. Finally, commit using git commit -a." We also say (in the paragraph after that) that the same is true for updating the layouts. Please let me know if you disagree with the above. Scott
signature.asc
Description: PGP signature
