On 2016-03-30, Richard Heck wrote:
> On 03/30/2016 11:26 AM, Guenter Milde wrote:
>> Dear Lyxers,
>> the "acmsiggraph" document class has been a source for headaches recently
>> due to an incompatible new version under the old name.
>> I propose a patch which I ask you to review also under the perspective that
>> this may become an example for further handling of such cases (see the
>> "guide on updating layouts" thread).
>> Idea:
>> * Keep the old layout working for old documents
>> (this does not prevent fixes that don't lead to incompatibilities).
>> * Change the GUI name to tell prominently that this is a "versioned" layout
>> (in this case also for an obsolete version).
> I don't see an "obsolete version" tag in the old layout, as you
> suggested in the other thread (and which seemed like a good idea).
Sorry, this seems to be the patch from before I changed the old layout.
See below for the current version.
>> * Add a new layout that supports the new *.cls version in a clean way.
>> In this case, the new layout imports the old one. Alternatively, the
>> old layout could be based on the new one.
> My only suggeestion (I don't use this class so can't comment
> intelligently on the implementation) would be to do it the other way
> around. The reason is just that it seems that would make maintenance
> easier. Presumably, changes we might need to make would really be for
> the new version of the class. It would also make it easier to release
> yet another version of this one, if that were necessary.
However, it is more work, morec changes, more ways to break something But
yes, at least when the next incompatible version comes out, it should be
old importing new.
Günter
diff --git a/lib/layouts/acmsiggraph.layout b/lib/layouts/acmsiggraph.layout
index 388b1dd..a147120 100644
--- a/lib/layouts/acmsiggraph.layout
+++ b/lib/layouts/acmsiggraph.layout
@@ -1,15 +1,23 @@
-#% Do not delete he line below; configure depends on this
-# \DeclareLaTeXClass[acmsiggraph,comment.sty,lineno.sty]{ACM SIGGRAPH}
+#% Do not delete the line below; configure depends on this
+# \DeclareLaTeXClass[acmsiggraph,comment.sty,lineno.sty]{ACM SIGGRAPH (v 0.9,
obsolete)}
# \DeclareCategory{Articles}
# ACM SIGGRAPH acmsiggraph textclass definition file.
# Author : Uwe Stöhr
#
-# We use acmsiggraph.cls, the Sigplan class file that can be
-# downloaded from
-# http://www.siggraph.org/publications/instructions
+# This layout is for acmsiggraph.cls versions below 0.92.
+# It is kept for existing documents (although they may fail to compile with
+# a current acmsiggraph.cls due to removed LaTeX commands).
#
-# ACM style files can be obtained at
-# http://www.acm.org/sigs/pubs/proceed/template.html
+# New contributions to to ACM SIGGRAPH should use the current document class
+# and template supported by acmsiggraph0-92.layout.
+# See http://www.siggraph.org/learn/instructions-authors
+#
+# Versions:
+# 0.9 Uwe Stöhr
+# 0.9a 2016-03-30 Günter Milde
+# Document incompatibilities introduced with v 0.92,
+# add version info to GUI name.
+# Add InTitle to Title, Author, and Teaser (no ERT \maketitle required).
Format 59
@@ -21,7 +29,7 @@ DefaultStyle Standard
ClassOptions
FontSize 9|10|11|12
-End
+End
DefaultFont
Family Roman
@@ -106,29 +114,28 @@ End
Style "TOG project URL"
CopyStyle "TOG online ID"
LatexName TOGprojectURL
- KeepEmpty 1
- LabelString "Project URL:"
+ LabelString "Project URL (unsupported since v0.92
2015/11/04):"
End
Style "TOG video URL"
CopyStyle "TOG project URL"
LatexName TOGvideoURL
- LabelString "Video URL:"
+ LabelString "Video URL (unsupported since v0.92
2015/11/04):"
End
Style "TOG data URL"
CopyStyle "TOG project URL"
LatexName TOGdataURL
- LabelString "Data URL:"
+ LabelString "Data URL (unsupported since v0.92 2015/11/04):"
End
Style "TOG code URL"
CopyStyle "TOG project URL"
LatexName TOGcodeURL
- LabelString "Code URL:"
+ LabelString "Code URL (unsupported since v0.92 2015/11/04):"
End
@@ -139,7 +146,6 @@ NoStyle Date
# modify the Title definition from stdtitle.inc
Style Title
- InTitle 0
InPreamble 1
Font
Family Sans
@@ -149,7 +155,6 @@ End
# modify the Author definition from stdtitle.inc
Style Author
- InTitle 0
InPreamble 1
End
@@ -176,18 +181,21 @@ Style Teaser
Margin Dynamic
LatexType Command
LatexName teaser
+ InTitle 1
+ InPreamble 1
Category FrontMatter
ParSkip 0.4
BottomSep 0.5
Align Left
LabelSep xx
LabelType Static
- LabelString "Teaser image:"
+ LabelString "Teaser figure:"
LabelFont
Series Bold
Size Normal
Color Green
EndFont
+ # TODO: support caption numbering (not Sensless!!!)
End
@@ -240,7 +248,7 @@ InsetLayout "Flex:CRcat"
LatexType command
LatexName CRcat
Decoration classic
- LabelString "CR category"
+ LabelString "CR category (deprecated, see
www.siggraph.org/learn/instructions-authors)"
Font
Color foreground
Size Small
@@ -302,4 +310,3 @@ Style Acknowledgments
LabelType Above
LabelString "Acknowledgments"
End
-
