On 02/03/2016 06:41 AM, Jean-Marc Lasgouttes wrote:
Here is a series of patches that came from frustration with bug #9955.
The main idea was to have different mouse cursor when clicking would
select a tabular row/column. This would make the feature much more
discoverable.
0001: the infrastructure. I need to add a parameter BufferView to
Inset::clickable
0002: implement clickable for InsetTabular. This is enough to make the
magic happen. The only strange thing is that for column selection
there is no margin above/below the tabular. I have used a margin
inside the tabuar (6 pixels), but this may prove annoying. Testing
will tell.
000[345]: when implementing 0001 I discovered that many
display-related mutable variables in InsetCollapsable were not bv
dependent, which is definitely bad (think split views). These patches
fix that. I think this fixes #9756 and probably some other split-view
bugs.
This patches are not for 2.2.0 (unless people ask for it). I think
0001+0002 can be safely backported to 2.2.x though; I am less sure
about the other part, which requires testing, but it is not terribly
risky IMO.
Looks pretty sensible, but I agree maybe it is better to wait until
after 2.2.0. I also think the whole thing could be committed to 2.2.x at
that time. It should get plenty of testing that way.
Richard
