Re: [LyX/master] Always place the cursor before a separator inset when clicking

[Enrico Forestieri]

On Tue, Jan 19, 2016 at 05:19:24PM -0500, Scott Kostyshak wrote:
> On Sat, Jan 16, 2016 at 04:41:26PM +0100, Enrico Forestieri wrote:
> > commit 55b3374f3e3047a0aa7584e0737d1fcd40fe6809
> > Author: Enrico Forestieri <for...@lyx.org>
> > Date:   Sat Jan 16 16:41:04 2016 +0100
> > 
> >     Always place the cursor before a separator inset when clicking
> 
> Note that this commit might have triggered the assertion #9936.

Thanks. The attached patch fixes it for me.

-- 
Enrico

diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 6de832d..81ebe79 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -2514,7 +2514,8 @@ bool BufferView::mouseSetCursor(Cursor & cur, bool select)
        bool update = leftinset;
        if (!do_selection && d->cursor_.inTexted()) {
                update |= checkDepm(cur, d->cursor_);
-               if (cur.pos() && cur.paragraph().isEnvSeparator(cur.pos() - 1))
+               if (cur.inTexted() && cur.pos()
+                       && cur.paragraph().isEnvSeparator(cur.pos() - 1))
                    cur.posBackward();
        }