Since we now require a +1 from another developer before a patch goes in,
I have seen some confusion because some reviewers have written something
like "looks OK" or "I have tested and nothing broke" and the author of
the patch is understandably not sure if what was written was a +1 or
not. If these statements were intended to be safe and to not give a +1
then good, I think they did their job and I see no problem with
continuing to use such phrases. They provide good feedback for the
daring LyX developer that does want to give a +1 so they still serve a
purpose.

But if you want to give a +1, either write "+1" or "please commit" to
make it clear that you support the author to push the patch for 2.2.0.

Scott

Attachment: signature.asc
Description: PGP signature

Reply via email to