Le 19/12/2015 13:54, Jürgen Spitzmüller a écrit :
Am Donnerstag 17 Dezember 2015, 16:43:32 schrieb Guillaume Munch:
I am confused now because it seems to be saying that outputting the
master preamble was already the intended meaning after the fix to 8445.
Jürgen, is this correct or am I misinterpreting?
Yes, I probably thought that this was the case (although it was not the
intended fix; the intended fix was to load the global/master macro definitions)
I miss what is the
effect of just setting is_child.
It adds the information to the output routine that the currently output buffer
functions as a child. The output routine then suppresses some output that
makes no sense for children. See the use of is_child in the source.
It also decides to use master params rather than params where appropriate.
To load the master preamble, one further addition would be necessary. See
attached patch. But as JMarc says, this change will not please everybody.
I tested the patch and it does not solve the reported problem. As I
understand it, it only loads the user preamble from the parent document.
In my test document, \upharpoonright is still not defined because the
macros are still not validated, and \texorpdfstring is still not defined
because the hyperref is still not loaded, so the situation is the same
as before the patch.
Do you have an opinion about changing
this line of yours with my patch?
I would prefer using the is_child parameter instead.
As for the long term, maybe we could have an option "Copy the master
preamble" in the document properties dialog in the future, and have this
preamble also validated against the macros that are included from master.
A proper solution would be the option to select between two modes: Inherit
params from master or keep own params. In some documents, both modes make
sense at different times.
Let me ask naively, what is the expected difference with unchecking
"Select master document"? (apart from the fact that we need to close the
master document and reopen the child after this, which is a bug
obviously, and the fact that the former parent document is forgotten on
reopening, making it unconvenient to re-enable)