Am Sonntag, 13. Dezember 2015 um 13:25:00, schrieb Georg Baum 
<georg.b...@post.rwth-aachen.de>
> Kornel Benko wrote:
> 
> > +           // Remove eventually added superfluous "/"
> > +           filepath = subst(filepath, "//", "/");
> 
> This one breaks UNC file names: 
> https://en.wikipedia.org/wiki/Path_(computing)#Uniform_Naming_Convention

Ah, yes. I didn't dare to remove "/" from "/systemlyxdir/".

> After thinking more about a possible solution I realized that prefixIs() is 
> unsafe as well: If sysdir is "/usr/local/lyx22", and filepath is 
> "/usr/local/lyx2/lib/doc/Userguide.lyx", then prefixIs(sysdir, filepath) 
> returns true, and the resulting path will be 
> "/systemlyxdir/2/lib/doc/Userguide.lyx", which is obviously wrong.
> 
> The attached patch fixes this. OK?
> 

Works for me. I'd say yes.

> Georg

That was a very short lived patch. RIP :)

        Kornel

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to