Am Samstag, 12. Dezember 2015 um 22:52:13, schrieb Guenter Milde 
<mi...@users.sf.net>
> Dear Kornel,
> 
> On 2015-12-11, Kornel Benko wrote:
> > Am Freitag, 11. Dezember 2015 um 21:51:41, schrieb Guenter Milde 
> > <mi...@users.sf.net>
> >> On 2015-12-11, Kornel Benko wrote:
> >> > Am Freitag, 11. Dezember 2015 um 12:53:41, schrieb Uwe Stöhr 
> >> > <uwesto...@web.de>
> 
> >> > It is not, that I am criticizing that the docs are designed for
> >> > pdflatex. (Which itself is not valid for japanese docs). 
> >> > It is only the removal from the test suite.
> 
> >> Problem: the "right thing" (marking the intended output format in the
> >> files) had the wrong side-effect of no longer testing other formats:
> 
> >> * up to now, the manuals were designed for pdflatex (except for the
> >>   japanese), but this was not documented (besides some posts to the
> >>   devel-list).
> 
> >>   The tests with other formats highlighted this omission and let to
> >>   improvement of the documentation: the intended "design format" is now
> >>   indicated in the documents »the LyX way«" -- specifying the default
> >>   output format.
> 
> >>   This does not prevent export to other formats, it only controls the
> >>   binding of the "view" and "update" buttons and menu entries.
> 
> >> * the test suite seems to create tests
> 
> >>   - for a set of output formats, if there is no explicit default output
> >>     format of the to-be-tested document
> 
> >>   - only for the default output format, if it is set.
> 
> > Yes, and this was done by intend. We wanted to have default output
> > format only if really necessary. And in this case we 'knew', that other
> > formats are not working. Now, all docs are marked this way.
> 
> However, regarding the docs, the test suite could treat "pdf2" just like
> "default".

Yes, we could do it. But the logic starts to be more and more confusing.

> Before the recent changes (at 3a7ec39a790/lyxgit 2015-12-09) there were
> just 4 instances of \default_output_format pdf2:
>  (|es|de|fr|ja)/Math.lyx

True, that was done _after_ investigating.

> All of these are also handled by the *Tests categorization pattern files:
> 
> suspiciousTests:27:export/.*/es/(Math|UserGuide|ejemplo_con_lyx)_dvi3_systemF
> suspiciousTests:42:export/doc/(es/|fr/)Math_dvi3_systemF
> suspiciousTests:115:export/doc(|/de|/es|/fr)/Math.*systemF
> suspiciousTests:116:export/doc/(|de/|es/|fr/)Math_(dvi3|pdf5)_texF 
> 
> ignoredTests:10:export/.*/ja/.*_(pdf[245]|dvi3).*
> 
> 
> The full set of non-default settings in doc/* is:
> 
> /usr/local/src/lyx/lib/doc/es/Math.lyx:151:\default_output_format pdf2
> /usr/local/src/lyx/lib/doc/Math.lyx:152:\default_output_format pdf2
> /usr/local/src/lyx/lib/doc/fr/Math.lyx:156:\default_output_format pdf2
> /usr/local/src/lyx/lib/doc/de/Math.lyx:164:\default_output_format pdf2
> /usr/local/src/lyx/lib/doc/ja/Formula-numbering.lyx:63:\default_output_format 
> pdf
> /usr/local/src/lyx/lib/doc/ja/LaTeXConfig.lyx:24:\default_output_format pdf
> /usr/local/src/lyx/lib/doc/ja/Shortcuts.lyx:51:\default_output_format pdf
> /usr/local/src/lyx/lib/doc/ja/DummyDocument2.lyx:24:\default_output_format pdf
> /usr/local/src/lyx/lib/doc/ja/Math.lyx:187:\default_output_format pdf2
> /usr/local/src/lyx/lib/doc/ja/DummyDocument1.lyx:24:\default_output_format pdf
> /usr/local/src/lyx/lib/doc/ja/MergedManuals.lyx:34:\default_output_format 
> xhtml
> /usr/local/src/lyx/lib/doc/MergedManuals.lyx:34:\default_output_format xhtml

Don't know, how you get this list.
I see there 99 entries (out of 107)
        # cd lib/doc
        # find . -name \*.lyx | xargs egrep default_output_format| egrep -vw 
default|wc

> (I did not test for examples and templates, though.)
> 
> ...
> 
> > We have to distinguish somehow if some formats are not allowed (because
> > for example the file is written specifically for creating html) or only
> > not desired. I don’t know how. The best (for the test suite) would be a
> > format change, describing available output formats. ATM, we have to
> > guess.
> 
> 
> Actually, for the manuals I see not much of a change if we ignore the
> default_output_format setting for now. 
> 

I will try.

> Proposal (too late for 2.2.0 ?)
> 
> a) use the "default output format" setting for the recommended format

OK, that will be then of no relevance for tests, if at the same time "excluded 
output formats" is set.

> b) add a new (expert) setting "excluded output formats"
> 
>    - as a key word for modules and layout files

+1

>    - possibly also to Document>Settings

+1

> c) consider excluding more output formats based on BufferParams, e.g.
> 
>    * pdf[245] and dvi3 if the language is Japanese

Such things are difficult to handle. It suggest the same logic be implemented 
in tests and in BufferParams.

>    * XeTeX with TeX fonts unless the inputenc is ASCII
> 

We are setting it already in that case.

> 
> With b), it would also be possible to prevent wrong output for non-working
> formats that don't result in an error.

yes.

> Examples: 
> 
> * es/*_pdf[45]_TeXF - Spanish
>   Intro LyX with Xe/LuaTeX and TeX fonts: due to a Babel bug the babel
>   autostrings are wrong (and sometimes fail).
> 
> * examples/seminar*(pdf2|pdf5|dvi3)
> 
> 
> Günter

        Kornel

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to