Uwe Stöhr wrote: > I tried this but this doesn't make a difference. Also if I comment out > the cxx11 part in regex.h the compilation fails as soon as I set > > set(LYX_USE_CXX11 1) > > I then get many of these: > > D:\LyXGit\Master\src\tex2lyx\table.cpp(284): error C3861: 'min': > identifier not found
This is probably a side effect of less unneeded includes in C++11 mode. std::min is declared in <algorithm>, but table.cpp does not include that header. This is wrong, if it uses std::min then it needs to include <algorithm> Does the error go away if you add the line #inlude <algorithm> to table.cpp? If yes, then please do so for all files that complain about std::min and std::max. You have my +1 for this in advance, since these files did only complain by chance previously (<algorithm> was included indirectly by some other header). > So i am relatively sure that we just need to allow std_regex for MSVC > while cxx11 is kept disabled for MSVC. That does not make sense. std::regex is not part of C++98, it is only part of C++11. Unfortunately I lost a bit track of the latest state of the patches. Kornel, how would the final version look like (assuming that the errors above can be fxied, and that we do not want to enable C++11 by default, but let the user choose by adding -DLYX_USE_CXX11=ON to the cmake command line? Georg
