Am Montag, 16. November 2015 um 21:01:19, schrieb Guenter Milde <mi...@users.sf.net> > On 2015-11-16, Kornel Benko wrote: > > Am Montag, 16. November 2015 um 14:17:23, schrieb Scott Kostyshak > > <skost...@lyx.org> > >> On Mon, Nov 16, 2015 at 06:51:08PM +0100, Kornel Benko wrote: > >> > commit b835c454ece6f1f8984664bf07974f4341bfd30c > >> > Author: Kornel Benko <kor...@lyx.org> > >> > Date: Mon Nov 16 18:47:34 2015 +0100 > >> > > >> > ATM, the latex comments in user preamble are removed before > >> > export test. > > >> This is just meant to be temporary right? > > > Yes temporary, until we handle non-ascii characters in comments gracefully. > > I don't think we need to remove LaTeX comments nor remove non-ASCII chars > from the documents. Also, I don't think this is worth fixing in LyX. > Remember, that this is just a warning that normally only affects > characters not encodable in the chosen "inputencoding". > > Problematic is only the case "XeTeX with TeX fonts", because here we need > inputenc==ASCII even if the setting in the doc is different. > > For documents that explicitly set inputenc==ASCII (a use case would be > 7-bit safe use/transfer of the exported LaTeX file) we can expect that > the author avoids non-ASCII characters in the user preamble (and fix > documents that ship with LyX with this setting). > > > > I tested also the suspended cases, but no improvement either. > > Probably, there are other reasons for failure that "kick in" once the > first obstacle is removed. |: Remember, XeTeX with TeX fonts is fragile :| > > > Commit or not commit, that’s the question ... > > IMO, the test-script should somehow differentiate between LyX warning and > LyX error and not treat a warning as test failure. Maybe it already does? >
It is not the test script return failure. It is lyx itself interpreting latex
result.
If lyx exit != 0, then there is no choice for the test IMHO.
> Günter
Kornel
signature.asc
Description: This is a digitally signed message part.
