On Sun, Sep 20, 2015 at 08:48:40PM +0200, Georg Baum wrote: > commit aab1b145a57c3e6eedb046410e8ed35bb5ad2c97 > Author: Georg Baum <b...@lyx.org> > Date: Sun Sep 20 20:47:33 2015 +0200 > > Fix missing xhtml output found by cppcheck > > Actually I don't know if this operator is used at all, but if it exists > then > it must output something. > > diff --git a/src/output_xhtml.cpp b/src/output_xhtml.cpp > index 959262d..9463573 100644 > --- a/src/output_xhtml.cpp > +++ b/src/output_xhtml.cpp > @@ -495,7 +495,7 @@ XHTMLStream & XHTMLStream::operator<<(char_type c) > XHTMLStream & XHTMLStream::operator<<(char c) > { > clearTagDeque(); > - string const d = html::escapeChar(c, escape_); > + os_ << html::escapeChar(c, escape_); > escape_ = ESCAPE_ALL; > return *this; > }
Many export ctests are failing after this commit. One example is if you open up the Additional.lyx manual and export to XHTML. I get a "LyX has caught an exception" message. Or if you do it on the command line I get: $ lyx -e xhtml Additional.lyx Error 22 returned from iconv_open(out_cd_): Invalid argument terminate called after throwing an instance of 'lyx::iconv_codecvt_facet_exception' what(): iconv problem in iconv_codecvt_facet initialization Aborted (core dumped) Let me know if you are unable to reproduce. Scott