Le 12/09/15 18:43, Jean-Marc a écrit :
commit 61f02710317b99a050346a0c95c02fcdd457bfca
Author: Jean-Marc <lasgout...@lyx.org>
Date: Sat Sep 12 18:40:52 2015 +0200
Add missing braces
Coverity issue 23506.
This is an example of a bug found by coverity amidst lots of nit
picking. However doing the boring part is important since it allows to
make the important part visible.
I encourage developers with free time (ha !) to register on coverity and
ask for access to
https://scan.coverity.com/projects/4164
BTW Liviu, could you update the source tree at coverity?
JMarc
@@ -2869,10 +2869,11 @@ QTreeWidgetItem *
PrefShortcuts::insertShortcutItem(FuncRequest const & lfun,
QList<QTreeWidgetItem*> const items =
shortcutsTW->findItems(lfun_name,
Qt::MatchFlags(Qt::MatchExactly | Qt::MatchRecursive),
0);
for (int i = 0; i < items.size(); ++i) {
- if (items[i]->text(1) == shortcut)
+ if (items[i]->text(1) == shortcut) {
newItem = items[i];
break;
}
+ }
// if not found, this unbind item is KeyMap::UserExtraUnbind
// Such an item is not displayed to avoid confusion (what is
// unmatched removed?).
