On Mon, Jul 6, 2015 at 8:33 AM, Guenter Milde <mi...@users.sf.net> wrote: > Dear LyX developers, > > after years of comments and patches, I just pushed my first commit to the > LyX repository. http://www.lyx.org/trac/changeset/c56f0538a00/lyxgit
Great! I'll look forward to your commits. > This is a minor fix for the clash between marvosym and bbding packages. > Please tell me if something went wrong or should have been done otherwise. > I want to play nice but beg your patience. Looks good to me. If you want a picky comment (and one that I think we often do not follow here): some people prefer the first line of a git commit to be 50 characters or less. I'm not sure why. I think there are some who prefer that for the commit you use your @lyx.org email address. I forget why. I think the argument was that your personal email address could someday change where your @lyx.org address would remain constant. On the other hand, I think Uwe is (sometimes?) not able to access his @lyx.org email so it actually makes more sense to contact him on a different address. I don't remember if we decided on a policy. Some general advice is that on master in some of your commits (I don't think this one), you might want to edit the file lib/RELEASE-NOTES and on branch the file status.21x What I personally do is I first think about whether my commit will likely be backported to branch. If not, I look at lib/RELEASE-NOTES and see if my commit fits in any of the categories there. Scott
