Appearently, I have to attract more attention.

[EMAIL PROTECTED] (Lars Gullik Bj\onnes) wrote:

> +#ifdef __EMX__
> +       ::unlink(to.c_str());
> +#endif          
> 
> Why not lyx::unlink(to); ?

Simply, I overlooked it.

> To me it look good and certainly a step in the right direction.
> 
> I have so far only looked at the diff.

Anything else?

For example, I'd like to know your opinion on system_tempdir.
I thought it not very comfortable to declare a global variable as
extern in many files, so I put it into class os, although the
handling it was independent of OS's.

Also os::init() is called from other os:: methods in the OS/2
implementation and currently I use a hackish check for (argc != 0)
to avoid multiple initialization in addition to static bool initialized.
Is there any better way?

Regards,
        SMiyata

Reply via email to