On Thu, Jun 4, 2015 at 3:05 PM, Enrico Forestieri <for...@lyx.org> wrote: > On Thu, Jun 04, 2015 at 02:44:56PM -0400, Scott Kostyshak wrote: >> On Thu, Jun 4, 2015 at 2:34 PM, Scott Kostyshak <skost...@lyx.org> wrote: >> > On Thu, Jun 4, 2015 at 2:31 PM, Enrico Forestieri <for...@lyx.org> wrote: >> >> On Thu, Jun 04, 2015 at 06:33:28PM +0100, Guillaume M-M wrote: >> >>> >> >>> 2) an assertion violation that happen on copy-paste with preview (does >> >>> not >> >>> happen without preview). This is a regression in master, does not happen >> >>> in >> >>> the stable branch. >> >> >> >> I can reproduce the assertion. Bisect points at 73460423 and it was >> >> backported to stable at 6ac04e21 where it asserts in the same way. >> > >> > Ah thank you for catching this and bisecting. I will revert in branch >> > and master. >> >> Can someone please confirm that I should indeed revert? >> I took a look at lyx-preview-explosion.lyx and I can indeed reproduce >> the assertion. My guess though is that the referenced commits expose a >> different bug that has to do with previews and macros. But in the end >> from a user perspective it is a regression. Thus, I think I should >> revert. > > Wouldn't it be better trying to understand why it asserts such that it > can be avoided?
Yes much better. However, we are close to release so I was thinking to revert in the meantime. And second, I don't understand the underlying code involving macros at all so it would be up to someone else to do that. From what I remember of previous issues regarding preview + macro, this is a complicated issue over my head. Scott
