On Mon, May 18, 2015 at 10:42:03AM +0200, Jean-Marc Lasgouttes wrote:
> Le 16/05/2015 19:52, Enrico Forestieri a écrit :
> >commit 62d36bf04d436c83ddace8aeaf4dbd493d674cdf
> >Author: Enrico Forestieri <for...@lyx.org>
> >Date: Sat May 16 19:51:53 2015 +0200
> >
> > Correctly load documents moved elsewhere after save.
>
> Now clang complains because of the new InsetCommand::read() signature (see
> below).
>
> Solutions include changing the name of the new method or declaring such a
> mathod at Inset level if it makes sense.
Should be fixed now.
> Some documentation of the Buffer
> const * parameter would be useful too. Is it supposed to be the buffer of
> the Inset or something else?
It is only needed for accessing the includedFilePath() method, so any will do.
> ../../master/src/insets/InsetCommand.h:69:7: warning:
> 'lyx::InsetCommand::read'
> hides overloaded virtual function [-Woverloaded-virtual]
> void read(Lexer & lex, Buffer const * buf) { p_.read(lex, buf); }
> ^
> ../../master/src/insets/Inset.h:460:15: note: hidden overloaded virtual
> function
> 'lyx::Inset::read' declared here: different number of parameters (1 vs
> 2)
> virtual void read(Lexer &) {}
> ^
> 1 warning generated.
>
>
--
Enrico
