2015-05-18 12:51 GMT+02:00 Uwe Stöhr:

>
> > since the count values change when you add a new item to the combo,
>> whereas the value stays stable, no matter what you do with the combo.
>>
>
> Note that the only .count() I used counts the fixed QList containing the
> possible combobox item.
>

I also mean the combo->currentItem() count value.



>
> > I was not aware that we are supposed to ask before adding FIXMEs. Note
>> that FIXMEs are not accusations, should you have read it like such.
>>
>
> Communication is never wrong. I could have made a thinko so it would help
> to receive a question.
> To answer your fixme: I used the LaTeX name as parameter to be able to use
> them directly in InsetBox. For the colors the GuiName is identic to the
> LaTeX name but who knows what will be added in future.
>

I can see the reasoning, but I still think we should use the LyX name. You
only have to convert it once, in InsetBox::latex. Otherwise we could as
well just ditch the LyX names altogether.



>
> -----------------
>
> While we are at it, I have one open issue I cannot solve: Also before my
> changes, the box dialog offers to set a horizontal alignment of the box
> content. I failed to find out how this can be done. Maybe you have an idea
> or can give me a tip how to do this?
>

You mean display the alignment in theLyX workarea? No, I would have to
inspect the code to answer this.

Jürgen

PS. I'll commit the remainign changes I have done. Please ask if you have
questions.



>
> thanks and regards
> Uwe
>
>

Reply via email to