On 05/03/2015 08:13 PM, Enrico Forestieri wrote:
On Sun, May 03, 2015 at 07:00:06PM -0400, Scott Kostyshak wrote:
On Sun, May 3, 2015 at 6:44 PM, Enrico Forestieri <for...@lyx.org> wrote:
The two methods browseRelToParent() and browseRelToSub() in GuiView.cpp
both return a relative path. The only difference is that the first one
returns an absolute path if it would start with "../", and the second one
if it does not start with "../". So, even if a relative path is possible,
an absolute path may be returned by both.
Both methods were introduced at http://www.lyx.org/trac/changeset/38915/lyxsvn
to fix bug 7540. I have read the discussion there, but could not make any
sense of why two methods behaving like that are necessary. A single method
returning a relative path (either starting or not by "../") would suffice.
A relative path is a relative path and this distinction makes no sense.
I think the following issue has relevant discussion:
http://www.lyx.org/trac/ticket/7122
Thanks for the pointer. I read that discussion and still don't see any
good reason for this behavior. If that's all, it is an arbitrary decision
which gives no benefits and only causes nuisances.
Having looked at that discussion, I don't see any point to the
distinction either. I suspect it is
an artifact of the pre-existing situation and that it should be removed,
as you propose. But
maybe for master only, in case it does break something.
But maybe JMarc has some idea? "AFAIK, I am the original author of this
hack."....
Richard
