Jean-Marc Lasgouttes wrote: > Some remarks: > > * in Text::insertChar, you do not test for typewriter font. Why is that? > What do you expect with LyX-Code, for example?
You are right, I forgot that. > * I still think that cycling would be good, that is \emdash+minus=>minus. OK, I'll implement that. My first goal was to replicate the old behaviour. > * When reading the file, I do not think that it is necessary to check > for the passthru status. Only the font counts IMO since everything is a > matter of font and ligatures. It replicates the old logic: If passthru was true, then the dashes were always output as is. This is not visible in the patch, since the early return for passthru == true in Paragraph::Private::latexSpecialChar() is still needed and not changed. This matters for passthru styles which do not use tt font (I don't know if we have any, but users could create some). > * why do you need to skip ERT in convert_dashes (lyx2lyx)? It looks like > a useless test to me. It is not needed, but since I need to test for math insets anyway I added it because it results in less \\twohyphens and \\twohyphens tokens. Georg
