Yes, that's fine by me. Richard Heck Stable Branch Maintainer Sent From My Droid 4 On Jan 8, 2015 2:45 AM, "Jean-Marc Lasgouttes" <lasgout...@lyx.org> wrote:
> Le 08/01/2015 01:17, Uwe Stöhr a écrit : > >> Am 07.01.2015 um 21:26 schrieb Jean-Marc Lasgouttes: >> >>> Are you sure of the line number? >>> >> >> Yes, this line reads >> >> if (pos < from + lyxrc.completion_minlength) >> >> Note that this is branch-only. In master Georg added this comment: >> > > Ahh. Branch-only. I missed that. > > >> // Work around MSVC warning: The statement >> // if (pos < from + lyxrc.completion_minlength) >> // triggers a signed vs. unsigned warning. >> // I don't know why this happens, it could be a MSVC bug, or >> // related to LLP64 (windows) vs. LP64 (unix) programming >> // model, or the C++ standard might be ambigous in the section >> // defining the "usual arithmetic conversions". However, using >> // a temporary variable is safe and works on all compilers. >> >> For safety reason this workaround should also be used in branch, right? >> > > Yes. I am sure Richard will agree. > > JMarc > >
