Am Mittwoch, 26. November 2014 um 11:21:06, schrieb Jean-Marc Lasgouttes <lasgout...@lyx.org> > Le 25/11/2014 19:39, Kornel Benko a écrit : > > The way it is now in cmake is to recompile every time the date changes. > > a.) Create temporary file lyx_date.tmp > > b.) check if different to lyx_date.h > > b1.) overwrite if yes. > > Currently we display both date and time in lyx -version. The time has > high probability of changing everytime. > > Note that this was done via explicit calls to __DATE__ and __TIME__ > preprocessor macros, so your lyx-date.h stuff does not help at all in > this regards. I think you are mixing the release date and the build date. > > > Please no. In case of recompiling version.cpp each time (even if not > > needed), > > there will be also unneeded linking too. > > I do not see another way to provide a build time that is actually > correct. Shall we get rid of the reference to a build time?
You mean, remove _TIME_ from src/version.cpp?
OK.
> Another option would be to get rid of this information altogether. I
> would think that version and commit hash a really enough. I never had
> any need to look up the build date/time.
I look up more for date then commit at first. Looking at commit_hash is 3
steps, and
I am lazy ...
# lyx dialog
# cd lyx_source
# git show
> >> I will next propose something for the release date: instead of the "not
> >> released" yet text, I propose to show the git commit if we have one.
> >> Would that make sense? I would think that the git commit is not needed
> >> for a real build, since in this case the release is tagged, and normal
> >> users do not need to know about this git business.
> >
> > +1
>
> I will do that when I have some time.
>
> JMarc
Kornel
signature.asc
Description: This is a digitally signed message part.
