Richard Heck wrote: > Nitpicking is exactly what we need here, for the reasons you give. I'd > suggest you go ahead and commit this, and we can deal with the > permissions issue next.
A slightly modified version which does not crash with circular symlinks is in at bf782ee02ac. Note that circular symlinks are not an issue for this particular use of copyTo() (such a file cannot be opened anyway), but I wanted to make sure to avoid such a crash for future users of copyTo. > That doesn't seem that bad, does it? We just need to find the original > permissions and then set the new file to have them as well? Yes. However, I believe this can be quite tricky if ACLs come into the play. > By the way, did you see this report? >> 2014-06-07 9:06 GMT+02:00 Scott Kostyshak: >> >> I've been getting the following message frequently when doing a >> normal save (and I have not been doing anything tricky such as >> editing the file externally): >> "Document xyz.lyx has been externally modified. Are you sure you want >> to overwrite this file?" >> I did not confirm that the above commit is what changed this >> behavior, but I thought I would check in to see if anyone else sees >> this? >> >> >> Yes, I see this, too. >> >> Jürgen > > Did you notice if this still happens with your patch? I saw the report, but I did not see it happening, with or without my patch. Scott and Jürgen, maybe you try to save on a network file system? Maybe it has something to do with the checksumming. Georg
