On Mon, Apr 28, 2014 at 5:44 AM, Jean-Marc Lasgouttes <lasgout...@lyx.org> wrote: > 28/04/2014 01:57, Scott Kostyshak: > > I am not sure that I understand the second patch: what are the changes in > commandPrep wrt libScritpSearch exactly? How come that you did not need to > change the documentation of the function?
The second patch was what I interpreted (and agreed with) what you wrote: On Mon, Feb 3, 2014 at 6:42 AM, Jean-Marc Lasgouttes <lasgout...@lyx.org> wrote: > * the special code to handle python in Systemcall::startscript is probably > also of interest to ForkedCall::startScript. It may be good to factor it out > somewhere, or even to include it in libScriptSearch (which should then be > renamed). The idea is that the command string is also parsed to look for python. This parsing can be done all together (with the macro substitutions) and that's why the function is renamed. > From what you write, it seems that the function is specialized for python > now. But we have other types of scripts, especially R scripts. Do these > still work? We do not parse looking for R commands in Systemcall::startscript as we were doing for Python. The second patch should not change any functionality, just organization (I will state this explicitly in the commit message). Just in case, I tested exporting the knitr manual and it exported successfully. Scott
