On 04/22/2014 03:31 AM, Benjamin Piwowarski wrote:
My commit was finally included in the master branch. Unless somebody
objects, I will undo it and apply Vincent patch which is cleaner.
Yes, I just merged everything mindlessly, so go ahead.
Richard
Benjamin
On 18 Apr 2014 at 18:27:27 , Vincent van Ravesteijn (v...@lyx.org
<mailto:v...@lyx.org>) wrote:
Op 18 apr. 2014 16:34 schreef "Benjamin Piwowarski" <bpiwo...@lyx.org
<mailto:bpiwo...@lyx.org>>:
>
> On 18 Apr 2014 at 16:24:07 , Vincent van Ravesteijn (v...@lyx.org
<mailto:v...@lyx.org>) wrote:
>>
>> > Objective-C compililation support with cmake and C++11
>> > author Benjamin Piwowarski <benja...@bpiwowar.net
<mailto:benja...@bpiwowar.net>>
>> > Sun, 9 Mar 2014 07:29:27 +0000 (08:29 +0100)
>> > committer Benjamin Piwowarski <bpiwo...@lyx.org
<mailto:bpiwo...@lyx.org>>
>> > Fri, 21 Mar 2014 01:18:09 +0000 (02:18 +0100)
>> > commit f115a12bf6c83de566e551dbed7735f894327017
>> > tree e963b5ca7d55ee52466580068f84d7c71c7776ec tree | snapshot
>> > parent e83606c98a3ba2b1bdc5134e37f0f841d1b9a222 commit | diff
>> > Objective-C compililation support with cmake and C++11
>> >
>> > This fixes an issue whe compiling with C++11 flags on: The
>> > objective-C clang compiler produces an error. This patch waits
>> > avoid including specific C++ flags and uses LYX_CPP_SPECIFIC_FLAGS
>> > to store the confliciting flags (for the moment, just C++11).
>>
>> Isn't the attached patch much nicer than
>>
>>
http://git.lyx.org/?p=lyx.git;a=commitdiff;h=f115a12bf6c83de566e551dbed7735f894327017
>>
>> The previous commit is postponing to add the --std=gnucxx11
compiler option in a fragile way until all objective c files were
processed. Instead, can't it be done like this, and only override the
option for the few objective-c files ?
>>
>> ________________________________
>
> Unfortunately, the attached patch does not resolve the problem. The
--std=c++11 is not a valid objective-c flag (at least for clang,
which is now the default in OS X).
>
Well, the -ansi flag (or its -std=... equivalent) overrides the
-std=c++11 flag. Why doesn't that work ?
Vincent
