Richard Heck schreef op 29-3-2014 18:35:
On 03/29/2014 07:28 AM, Vincent van Ravesteijn wrote:
Tommaso Cucinotta schreef op 29-3-2014 0:07:
On 28/03/14 18:07, Tommaso Cucinotta wrote:
Please commit to the 2.2-staging branch.
ok, no prob. I'll try to address your concerns in the new commit.
So, it's in 2.2-staging, with 2 commits, as per your suggestion.
Hmm, I don't see it.
Did you commit and forget to push?
However, plaintext() is often used for other things which feels a bit
wrong. Some insets have a toString function that just call plaintext
with a default OutputParams object, but I feel like this should be
the other way around. If no special make-up is needed for plaintext,
just return toString(). Also, the default OutputParams object often
produces the correct output, because the plaintext() function doesn't
use most of the params. However, this still is wrong. If the
plaintext function suddenly does care about dry_run, all the callers
are suddenly wrong.
You are the one hundred, thirty-second person to complain about this.
;-) And it's led to bugs. But it would takea lot of work to fix it.
Good, I hate to be alone with my opinions. I only wanted to say that
Tomasso's patch was not improving the situation, but was somehow hiding
the underlying mess by building some messy function on top of it.
Vincent
