Re: [LyX/2.2-staging] Draw a small red frame around preview images that are too small.

[Richard Heck]

On 03/21/2014 05:12 PM, Vincent van Ravesteijn wrote:

On Friday, March 21, 2014, Richard Heck <rgh...@lyx.org <javascript:_e(%7B%7D,'cvml','rgh...@lyx.org');>> wrote:

    commit 1bb7c3baafb636eb02c09ee651b4f7b7a5836b04
    Author: Richard Heck <rgh...@lyx.org>
    Date:   Wed Mar 19 12:43:21 2014 -0400

        Draw a small red frame around preview images that are too small.

    diff --git a/src/mathed/InsetMathHull.cpp
    b/src/mathed/InsetMathHull.cpp
    index e994d44..4c20625 100644
    --- a/src/mathed/InsetMathHull.cpp
    +++ b/src/mathed/InsetMathHull.cpp
    @@ -44,6 +44,7 @@
     #include "insets/InsetRef.h"
     #include "insets/RenderPreview.h"

    +#include "graphics/GraphicsImage.h"
     #include "graphics/PreviewImage.h"
     #include "graphics/PreviewLoader.h"

    @@ -410,7 +411,7 @@ ColorCode InsetMathHull::standardColor() const
     }


    -bool InsetMathHull::previewState(BufferView * bv) const
    +bool InsetMathHull::previewState(const BufferView *const bv) const

We usually don't constify pointers like this. Any specific reason you change it here?

I guess my usual rule is: If it can be const, it should be const.

Richard