19/03/2014 15:49, Vincent van Ravesteijn:
It looks good. When I pushed it yesterday it wouldn't compile because
you recently introduced a call to a function that you renamed in this
branch, but I assume you fixed it.
Yes, this is something I already had to do in my big 1-commit-rebase
version.
I will move this back to str-metrics and stop rewriting it.
It would be a good time to introduce a testing framework and write
some tests for the functions you mangled ;) (I know you don't like
that).
Sure, it would be nice. But as you have well understood, I hate that :)
Besides, I first have a list of already identified bugs to fix.
Actually, I'd like to put the branch in a stage that would allow to land
it ASAP after 2.1, so that remaining bugs get exposed.
In particular, I will really need at least one competent Hebrew user and
one competent Arabic user (who could be the same one, who knows).
or you can just overwrite the str-metrics branch with the
str-metrics-rebased branch by:
$ git checkout str-metrics-rebased
$ git push features str-metrics-rebased:str-metrics
I'll do that.
JMarc
